feat: generate EN 16931 compatible invoices #3159
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nijel
added
the
backlog
There was a problem hiding this comment.
Pull Request Overview
This PR adds EN 16931 (European standard e-invoicing format) XML generation and embeds it into PDF invoices using Factur-X format. The changes enable compliance with European e-invoicing standards by generating structured invoice data alongside the visual PDF representation.
Key changes:
- Integration of PyCheval library for EN 16931 XML generation and Factur-X for PDF embedding
- New
get_en_16931_xml()andgenerate_en_16931_xml()methods to create standardized e-invoice XML - Modified PDF generation to embed EN 16931 XML using Factur-X format
- Fixed bug in Money S3 XML generation where country was referenced incorrectly
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| weblate_web/invoices/models.py | Adds EN 16931 XML generation methods, embeds e-invoice in PDF, fixes country code reference in Money S3 XML |
| weblate_web/invoices/tests.py | Adds validation for generated EN 16931 XML using drafthorse validator |
| requirements.txt | Adds drafthorse, factur-x, and PyCheval dependencies for e-invoicing support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| billed_total=Money( | ||
| self.total_discount, self.get_currency_display() | ||
| ), | ||
| tax_rate=self.vat_rate, |
There was a problem hiding this comment.
The discount line item should use self.vat_rate or None for consistency with other line items (line 740). When vat_rate is 0 (falsy), the tax_rate should be None, not 0.
Suggested change
| tax_rate=self.vat_rate, | |
| tax_rate=self.vat_rate or None, |
weblate_web/invoices/models.py
Outdated
| pdf_bytes = generate_from_binary( | ||
| buffer.getvalue(), generate_xml(self.get_en_16931_xml()) | ||
| ) | ||
| # pdf_bytes = embed_invoice_in_pdf(buffer, self.get_en_16931_xml()) |
There was a problem hiding this comment.
Commented-out code should be removed. If this is an alternative implementation that might be needed later, it should be documented in a TODO comment or issue tracker instead.
Suggested change
| # pdf_bytes = embed_invoice_in_pdf(buffer, self.get_en_16931_xml()) |
weblate_web/invoices/models.py
Outdated
| line_items=line_items, | ||
| type_code=type_code, | ||
| seller=TradeParty( | ||
| name="Weblate s.r.o", |
There was a problem hiding this comment.
Company name is missing a period after 'r.o'. It should be 'Weblate s.r.o.' (with a trailing period) for proper Czech company designation.
Suggested change
| name="Weblate s.r.o", | |
| name="Weblate s.r.o.", |
❌ 38 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
nijel
force-pushed
the
en16931
branch
2 times, most recently
from
ad6ee0e to
a5473ae
Compare
This is a proof of concept, I had to use several libraries to make it work. Outstanding issues: - The VAT validation fails because of zfutura/pycheval#30 - We really need full validation to be part of the tests, needs to be investigated. - There are definitely issues with generated XML.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof of concept, I had to use several libraries to make it work.
Outstanding issues: