-
-
Notifications
You must be signed in to change notification settings - Fork 86
TurboModule support & improvements #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
hey @Preeternal I figure I'd put this here since your fork doesn't have issues.
and the build errors out on
I'll happily dump the entirety of the xcode logs if you like, its just a lot. Also, this was an ios build (obviously) and I am on expo 53. I'll happily share anything you need to help get this working! Thank you again for updating the package! |
Hey, thanks a lot for testing it out and for the kind words! 🙏 At the moment I’ve verified the library works 100% on a clean React Native new-arch setup (outside Expo). I haven’t yet tried it inside Expo/EAS, so there might be some quirks specific to their build service or config. I’ll take a look at Expo/EAS integration soon — if you could indeed share the Xcode logs (at least the error section, not the full thousands of lines), that would speed things up. That way I can reproduce or patch whatever is failing on Expo side. For now, if someone isn’t tied to Expo, the package should build and run fine with a plain RN new-arch app. But I’ll dig into Expo compatibility so you don’t have to eject. |
Hey, quick update 👋 I actually went ahead and tested the fork thoroughly with Expo SDK 53 (both managed workflow and bare new-arch setup). Built and ran it locally via EAS CLI (eas build --local) and also on a physical device — everything came up clean. Couldn’t reproduce the 'DocumentScanner-Swift.h' file not found issue on my side. That said, I realize EAS Cloud sometimes behaves a bit differently from local, so I’ll try to add a defensive import for the Swift header soon, just to be safe. That tweak won’t affect plain RN builds, but should help smooth over edge-cases on Expo’s infra. So far, with plain RN + new arch the package is 100% stable, and Expo 53 works fine for me. If you could still share the relevant section of the failing Xcode logs from your EAS build, that’d help me zero in on what’s different in your environment. Thanks again for testing and reporting 🙏 |
There’s a decent chance it was totally on my end. I’m trying to go through Apple App Store submission right now, but will attempt to get another test going tonight. I only did the one test last time due to limited number of builds using Expo’s build service in the free tier but I may have to just pony up and pay for the service for a month to get my app over the line anyway 😅 Thank you for looking into it! And I’ll grab the logs as well and post them here just in case. |
@Waffleophagus This update fixes the intermittent Expo EAS iOS build failures (
Please try:
If you still see the header error, please share:
Thanks for testing—feedback appreciated. |
Hey @Preeternal thanks for your patience with me on not getting back to you. I was putting some final touches on my app that was just approved for the ios app store! (My first!!) I just got back around to looking at this and I don't know what happened the first time, but this time it worked like a charm! So thank you a ton for getting this updated. Its gonna be a key feature for my app. You rock! Waffleophagus |
Added
Changed
Fixed