PLATFORM-10117: Migrate UsingData to MW 1.43 #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wladekb
force-pushed
the
PLATFORM-10117-migrate-usingdata
branch
8 times, most recently
from
32e3560 to
9383c5c
Compare
wladekb
force-pushed
the
PLATFORM-10117-migrate-usingdata
branch
from
9383c5c to
8c05ad2
Compare
albertsko
reviewed
Feb 14, 2025
There was a problem hiding this comment.
Hi Wladek, I consider you a great engineer, but unfortunately I won't pass your PRs thru code review this time because of the issues below:
Detected some globals 🥶
global $wgNonincludableNamespaces; and global $wgHooks;
Please, use those imports within UsingDataHooks.php and UsingDataPPFrameDOM.php if needed.
use MediaWiki\Parser\Parser;
use MediaWiki\Title\Title;EDIT: sorry about the globals - they are fine, I forgot to bootstrap locally 🙇
Contributor
Author
|
globals were just removed, did I miss anything? |
albertsko
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.