feat: Add custom log level support with semantic ordering #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements custom log level functionality allowing users to define custom levels between existing built-in levels (e.g., NOTICE between INFO and WARN) without breaking existing APIs. Key Features: - Custom level registry system with thread-safe global registry - Semantic ordering support via IsBetween() method - Custom levels can be positioned between existing levels using specific int8 values - Stack trace and caller information properly handled for custom levels - Backward compatible - Level remains int8, no breaking changes Implementation Details: - New zapcore/customlevels package for level metadata management - CustomLevelMetadata struct with name, value, color, and metadata - RegisterCustomLevelBetween() for semantic positioning - Enhanced Level type with IsCustom(), Custom(), and IsBetween() methods - Fixed addStack logic in logger.check() to support custom levels - Updated encoder configurations for proper custom level handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements custom log level functionality allowing users to define custom levels between existing built-in levels (e.g., NOTICE between INFO and WARN) without breaking existing APIs.
Key Features:
Implementation Details: