Skip to content

Conversation

@djstrong
Copy link

fix infinite loop if number of sentences is smaller than number of sections (30)

fix infinite loop if number of sentences is smaller than number of sections (30)
@ai-nikolai
Copy link
Contributor

Thank you for submitting the Pull Request. Much appreciated.

Two comments at this stage:

  1. Could you add a test case for that? (So that also the exact problem is better understood)
  2. I am wondering about the min(1,) statement. It seems that when total/sections > 1 the result will be 1 and otherwise it will be less than 1. -> I am not fully sure how this solves the problem you have encountered. Could you elaborate, please? I think this is where the test case would come in handy.

All the best,
Niko

@djstrong
Copy link
Author

Sorry, it should be max.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants