Add the Prompt Builder #49
Conversation
JasonTheAdams
force-pushed
the
prompt-builder
branch
from
6e6e849 to
1cbbd0f
Compare
JasonTheAdams
force-pushed
the
prompt-builder
branch
from
165be6a to
c56bf85
Compare
|
@JasonTheAdams Thank you for your great work here. You accomplished the intended goal of this PR. I've some thoughts that may have some improvements in return will share over the files. Well Done 💯 |
There was a problem hiding this comment.
@JasonTheAdams This is very close. No other feedback on my end than what's left from the previous reviews.
| * @throws InvalidArgumentException If the prompt or model validation fails. | ||
| * @throws RuntimeException If no audio is generated. | ||
| */ | ||
| public function generateSpeeches(?int $candidateCount = null): array |
There was a problem hiding this comment.
I don't love this name - to me this sounds like multiple speeches as in "delivering a speech". But maybe it's what we need to do because the term "speech" like it's meant here doesn't really have a plural?
There was a problem hiding this comment.
Maybe generateSpeechFile and generateSpeechFiles?
There was a problem hiding this comment.
@felixarntz decided to we'll keep it, but preserve this gripe for posterity. 😄
This introduces the Prompt Builder, which is intended to be the primary face for Implementors to construct and execute prompts. See the "Fluent API" examples in the code examples in the Architecture doc.