Skip to content

Loading: do not translate early #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2025
Merged

Loading: do not translate early #47

merged 1 commit into from
Mar 4, 2025

Conversation

@kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Mar 3, 2025

Fixes #45

There are two things throwing doing_it_wrong for translating too early.

  1. The "name" setting. Resolved by setting name to "Secure Custom Fields" initially in case anything uses it super early and updating it to the translated version on the init hood.
  2. Loading the front form. This isn't needed immediately, but the initial constructor translates a few fields. Move all form loading to the init hook.

@kraftbj kraftbj merged commit 2b65f12 into trunk Mar 4, 2025
3 checks passed
kraftbj added a commit that referenced this pull request Mar 4, 2025
@kraftbj
Move items that need translation to init (#47)
9a2cbe9
kraftbj added a commit that referenced this pull request Mar 7, 2025
@kraftbj
Backport 6.4.1 stable release updates (#73)
708e591 
* Move items that need translation to init (#47)

* Build assets and documentation

* Update version to 6.4.1

* Update stable tag to 6.4.1

* Update stable tag

* Update release date
@kraftbj kraftbj added this to the 6.5.0 milestone Apr 14, 2025
@kraftbj kraftbj deleted the fix/45 branch April 14, 2025 16:15
@kraftbj kraftbj mentioned this pull request May 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.5.0

Development

Successfully merging this pull request may close these issues.

Update translation loading

2 participants

@kraftbj