Implement column metadata #209
Conversation
JanJakes
force-pushed
the
column-meta
branch
4 times, most recently
from
fec56d7 to
163fc67
Compare
JanJakes
force-pushed
the
column-meta
branch
2 times, most recently
from
d877817 to
6b05356
Compare
|
@adamziel I've got this to a point where I think we can merge it, including plenty of tests. It would be useful to advance the Adminer, phpMyAdmin, and other tool support. I can also create a follow-up ticket for what can be further improved (MySQLi flags, etc.). Maybe also all the |
| * This is used to compute the column metadata from the information schema. | ||
| */ | ||
| const COLUMN_INFO_MYSQL_TO_NATIVE_TYPES_MAP = array( | ||
| // Numeric data types: |
There was a problem hiding this comment.
can we sort it by mysqli type within each datatype group (int, string etc)? It seems like we'll be looking up entries in this mapping by that number a little bit. Alternatively, we could create a bunch of named constants and reference them here, e.g. self::MYSQLI_BIT etc.
There was a problem hiding this comment.
@adamziel As we already have multiple maps in the form of mysql-type-to-something, I was thinking about consolidating them into something like this:
It would be all in one place then, and likely more readable. Usage:
$sqlite_type = self::MYSQL_TYPE_MAP[$type][self::KEY_SQLITE_TYPE];
$implicit_default = self::MYSQL_TYPE_MAP[$type][self::KEY_MYSQL_IMPLICIT_DEFAULT];
...What do you think?
| * that have no records in the information schema (i.e., expressions). | ||
| */ | ||
| const COLUMN_INFO_SQLITE_TO_NATIVE_TYPES_MAP = array( | ||
| 'NULL' => array( 'NULL', 6, 0, 0 ), |
|
Nice! Yeah let's get it in. The limitations would be also nice to document in a comment within the code as that's where we'll be looking for this information. |
This PR implements emulation of
PDOStatement::getColumnMeta()values and adds support for$wpdb::get_col_info().This feature is necessary for support of MySQL tools like Adminer, phpMyAdmin, and others, as well as for any plugins that may rely on this functionality.
Resolves #190.