Skip to content

Add a database name fallback for early adopters of the new driver #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025
Merged

Add a database name fallback for early adopters of the new driver #226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions wp-includes/sqlite/db.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,21 @@
require_once __DIR__ . '/class-wp-sqlite-db.php';
require_once __DIR__ . '/install-functions.php';

/**
* The DB_NAME constant is required by the new SQLite driver.
*
* There are some existing projects in which the DB_NAME constant is missing in
* wp-config.php. To enable easier early adoption and testing of the new SQLite
* driver, let's allow using a default database name when DB_NAME is not set.
*
* TODO: For version 3.0, enforce the DB_NAME constant and remove the fallback.
*/
if ( defined( 'DB_NAME' ) && '' !== DB_NAME ) {
$db_name = DB_NAME;
} else {
$db_name = apply_filters( 'wp_sqlite_default_db_name', 'database_name_here' );
}

/*
* Debug: Cross-check with MySQL.
* This is for debugging purpose only and requires files
Expand All @@ -64,9 +79,9 @@
$crosscheck_tests_file_path = dirname( __DIR__, 2 ) . '/tests/class-wp-sqlite-crosscheck-db.php';
if ( defined( 'SQLITE_DEBUG_CROSSCHECK' ) && SQLITE_DEBUG_CROSSCHECK && file_exists( $crosscheck_tests_file_path ) ) {
require_once $crosscheck_tests_file_path;
$GLOBALS['wpdb'] = new WP_SQLite_Crosscheck_DB( DB_NAME );
$GLOBALS['wpdb'] = new WP_SQLite_Crosscheck_DB( $db_name );
} else {
$GLOBALS['wpdb'] = new WP_SQLite_DB( defined( 'DB_NAME' ) ? DB_NAME : '' );
$GLOBALS['wpdb'] = new WP_SQLite_DB( $db_name );

// Boot the Query Monitor plugin if it is active.
require_once dirname( __DIR__, 2 ) . '/integrations/query-monitor/boot.php';
Expand Down