Skip to content

Conversation

@hbhalodia
Copy link

@hbhalodia hbhalodia commented Nov 25, 2025

  • Update the wp_ajax_search_plugins action function to initialize the WP_Plugin_Dependencies class to correctly identiy the plugin dependency when plugin search.

Trac ticket: https://core.trac.wordpress.org/ticket/64288

Screencast

Screen.Recording.2025-11-25.at.4.17.01.PM.mov

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

github-actions bot commented Nov 25, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props hbhalodia, westonruter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@westonruter
Copy link
Member

This fixes the issue for me!

Before:

Screen.Recording.2025-11-25.at.17.07.34.mov

After:

Screen.Recording.2025-11-25.at.17.08.46.mov

@westonruter
Copy link
Member

The WP_Plugin_Dependencies::initialize() method is otherwise currently being called on:

  • src/wp-admin/plugins.php
  • src/wp-admin/plugin-install.php
  • The validate_plugin_requirements() function
  • The WP_Plugin_Dependencies::check_plugin_dependencies_during_ajax() method.

This last one indicates that it “Checks plugin dependencies after a plugin is installed via AJAX.” This is registered here:

// Register Plugin Dependencies Ajax calls.
add_action( 'wp_ajax_check_plugin_dependencies', array( 'WP_Plugin_Dependencies', 'check_plugin_dependencies_during_ajax' ) );

Question: Would it not make sense to hook in similarly for the search-plugins ajax action? I suppose ultimately the same effect is done since WP_Plugin_Dependencies::initialize() is added to wp_ajax_search_plugins(). The check_plugin_dependencies ajax action was added separately for plugin dependencies, whereas wp_ajax_search_plugins() already existed, to which WP_Plugin_Dependencies::initialize() can be added in the same way it was added top-level to the plugins.php and plugin-install.php admin screens.

@hbhalodia
Copy link
Author

hbhalodia commented Nov 26, 2025

Hi @westonruter, Thanks for reviewing the PR.

Yes, I agree that this should get initialized in the Ajax context, as it already being done for,

// Register Plugin Dependencies Ajax calls.
add_action( 'wp_ajax_check_plugin_dependencies', array( 'WP_Plugin_Dependencies', 'check_plugin_dependencies_during_ajax' ) );

Ultimately for search-plugins Ajax, this should get initialized and correctly identify the plugin dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants