-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Deactivate link is active for plugins required by others when searching #10547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
…rrectly identify plugin dependencies Core Trac - https://core.trac.wordpress.org/ticket/64288
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
This fixes the issue for me! Before: Screen.Recording.2025-11-25.at.17.07.34.movAfter: Screen.Recording.2025-11-25.at.17.08.46.mov |
|
The
This last one indicates that it “Checks plugin dependencies after a plugin is installed via AJAX.” This is registered here: wordpress-develop/src/wp-admin/admin-ajax.php Lines 173 to 174 in a107147
Question: Would it not make sense to hook in similarly for the |
|
Hi @westonruter, Thanks for reviewing the PR. Yes, I agree that this should get initialized in the wordpress-develop/src/wp-admin/admin-ajax.php Lines 173 to 174 in a107147
Ultimately for search-plugins |
wp_ajax_search_pluginsaction function to initialize theWP_Plugin_Dependenciesclass to correctly identiy the plugin dependency when plugin search.Trac ticket: https://core.trac.wordpress.org/ticket/64288
Screencast
Screen.Recording.2025-11-25.at.4.17.01.PM.mov
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.