Query Monitor plugin support #2415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
[Type] Enhancement
|
Anything I can do in QM to remove the need for this? |
|
Thank you for asking @johnbillion! This is a problem with Playground using That being said, let me CC @JanJakes who had some ideas about upstream changes in Query Monitor that would ease the integration with the SQLite plugin. |
|
The query monitor plugin now works on https://playground.wordpress.net 🎉 https://playground.wordpress.net/?plugin=query-monitor&login=yes&url=%2Fwp-admin%2F%23qm 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
WordPress/sqlite-database-integration#212 added support for the Query monitor in the SQLite integration plugin. However, it's not enough to make it work in Playground. The Query Monitor plugin short-circuits when the SAPI is set to
cli– which it always is in Playground. This PR sets a constant that tells the Query Monitor plugin to ignore the SAPI and run anyway.In addition, this PR also ships the latest SQLite integration plugin.
Ideally we'd set the correct SAPI, but that's a larger rabbit hole.
Testing Instructions (or ideally a Blueprint)
Go to http://127.0.0.1:5400/website-server/?plugin=query-monitor and confirm the query monitor is loading correctly.