Skip to content

Handle null service intents in onStartCommand #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Handle null service intents in onStartCommand #163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions android/src/main/java/flutter/overlay/window/flutter_overlay_window/OverlayService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,12 @@ public void onDestroy() {
@Override
public int onStartCommand(Intent intent, int flags, int startId) {
mResources = getApplicationContext().getResources();

if (intent == null) {
Log.w("OverlayService", "Received null intent in onStartCommand");
return START_STICKY;
}

int startX = intent.getIntExtra("startX", OverlayConstants.DEFAULT_XY);
int startY = intent.getIntExtra("startY", OverlayConstants.DEFAULT_XY);
boolean isCloseWindow = intent.getBooleanExtra(INTENT_EXTRA_IS_CLOSE_WINDOW, false);
Expand Down