fix: Include TestGlobals.hpp is using <> instead of quotations #2618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathbunnyru
reviewed
Sep 15, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2618 +/- ##
========================================
Coverage 81.94% 81.94%
========================================
Files 380 380
Lines 14230 14230
Branches 7852 7852
========================================
Hits 11661 11661
Misses 1433 1433
Partials 1136 1136 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mathbunnyru
requested changes
Sep 26, 2025
Comment on lines
+23
to
+27
| sed_script=$(mktemp) | ||
| for header in $all_local_headers; do | ||
| escaped_header=$(printf '%s\n' "$header" | sed 's/[\/&]/\\&/g') | ||
| echo "s|#include[[:space:]]*[\"<]$escaped_header[\">]|#include \"$header\"|g" >> "$sed_script" | ||
| done |
Collaborator
There was a problem hiding this comment.
Is it possible to make replacements directly, instead of generating code to make replacements?
| fi | ||
|
|
||
| # Get a list of all header filenames in src/ and tests/ (recursively, unique) | ||
| all_local_headers=$(find ./src ./tests -type f \( -name '*.hpp' -o -name '*.h' \) -exec basename {} \; | sort -u) |
Collaborator
There was a problem hiding this comment.
We don't have *.h files
| fi | ||
|
|
||
| # Get a list of all header filenames in src/ and tests/ (recursively, unique) | ||
| all_local_headers=$(find ./src ./tests -type f \( -name '*.hpp' -o -name '*.h' \) -exec basename {} \; | sort -u) |
Collaborator
There was a problem hiding this comment.
Do we need 2 implementations?
I mean using both main_src_dirs and all_local_headers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1642