Skip to content

Conversation

@mvadari
Copy link
Collaborator

@mvadari mvadari commented Sep 23, 2025

High Level Overview of Change

Title pretty much says it all. This is a one-line change to mark the featureSmartEscrow amendment as Supported::yes. This PR should not be merged until the rest of the Smart Escrow PRs are merged.

Context of Change

The purpose of this PR is to make it easier for those running the amendment locally or deploying it to a devnet, so they do not need to change the source code themselves to do so.

Type of Change

  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)

API Impact

N/A

Test Plan

CI passes.

@codecov
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.8%. Comparing base (c15947d) to head (4094631).
⚠️ Report is 336 commits behind head on ripple/smart-escrow.

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##           ripple/smart-escrow   #5811     +/-   ##
=====================================================
- Coverage                 78.9%   78.8%   -0.1%     
=====================================================
  Files                      823     825      +2     
  Lines                    73833   71242   -2591     
  Branches                  8593    8405    -188     
=====================================================
- Hits                     58263   56139   -2124     
+ Misses                   15570   15103    -467     

see 805 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mvadari mvadari changed the title chore: mark SmartEscrow as Supported::yes mark SmartEscrow as Supported::yes Sep 26, 2025
@mvadari mvadari force-pushed the ripple/se/supported branch from eedba2f to 0f6a558 Compare September 26, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants