Skip to content

Conversation

@a1q123456
Copy link
Collaborator

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@a1q123456 a1q123456 requested review from Tapanito and ximinez December 4, 2025 16:21
@a1q123456 a1q123456 force-pushed the a1q123456/pay-fee-into-the-pseudo-account-if-broker-removes-trustline-or-mpt branch 4 times, most recently from e73f1c6 to 6bec1f0 Compare December 4, 2025 16:24
@Tapanito Tapanito changed the base branch from develop to ximinez/lending-XLS-66-ongoing December 4, 2025 16:34
@Tapanito Tapanito requested a review from a team as a code owner December 4, 2025 16:34
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.1%. Comparing base (5224636) to head (6ff6be9).

Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                        @@
##           ximinez/lending-XLS-66-ongoing   #6108     +/-   ##
================================================================
- Coverage                            79.1%   79.1%   -0.0%     
================================================================
  Files                                 839     839             
  Lines                               71370   71371      +1     
  Branches                             8322    8324      +2     
================================================================
- Hits                                56453   56452      -1     
- Misses                              14917   14919      +2     
Files with missing lines Coverage Δ
src/xrpld/app/tx/detail/LoanPay.cpp 95.5% <100.0%> (+<0.1%) ⬆️
src/xrpld/app/tx/detail/LoanSet.cpp 91.4% <100.0%> (ø)

... and 1 file with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@a1q123456 a1q123456 force-pushed the a1q123456/pay-fee-into-the-pseudo-account-if-broker-removes-trustline-or-mpt branch from 6bec1f0 to 5e0a0cb Compare December 5, 2025 09:25
@a1q123456
Copy link
Collaborator Author

Let me add a new test case for it. Making it a draft temporarily.

@a1q123456 a1q123456 marked this pull request as draft December 8, 2025 12:36
@a1q123456 a1q123456 marked this pull request as ready for review December 8, 2025 13:55
@a1q123456
Copy link
Collaborator Author

Actually, let me convert this pr to a draft again for a similar fix.

@a1q123456 a1q123456 marked this pull request as draft December 8, 2025 13:57
@a1q123456 a1q123456 changed the title Pay the fee into the pseudo account if the broker removes the trustline or unauthorizes the mpt Check permissions in LoanSet and LoanPay Dec 9, 2025
@a1q123456 a1q123456 marked this pull request as ready for review December 9, 2025 10:43
@a1q123456 a1q123456 force-pushed the a1q123456/pay-fee-into-the-pseudo-account-if-broker-removes-trustline-or-mpt branch from 1468299 to 5dccd89 Compare December 9, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants