Skip to content

Conversation

@vlntb
Copy link
Collaborator

@vlntb vlntb commented Dec 9, 2025

High Level Overview of Change

Add missing lsfMPTCanLock flag check to LoanBrokerCoverClawback transaction to comply with XLS-66 specification requirements.

Context of Change

  • Added lsfMPTCanLock validation in LoanBrokerCoverClawback::preclaimHelper()
  • Added unit test to verify both lsfMPTCanClawback and lsfMPTCanLock flags are required

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@vlntb vlntb marked this pull request as ready for review December 9, 2025 16:28
@vlntb vlntb requested a review from ximinez December 9, 2025 16:29
@ximinez
Copy link
Collaborator

ximinez commented Dec 9, 2025

This PR essentially reverts commit 40cd573, which I recently added due to comment: #5270 (comment)

@vlntb
Copy link
Collaborator Author

vlntb commented Dec 10, 2025

This PR essentially reverts commit 40cd573, which I recently added due to comment: #5270 (comment)

Ok. If the consensus is that lsfMPTCanClawback can be set without lsfMPTCanLock. Then we can close this PR, as the system behaves as expected and concentrate on getting consistent results between local and network setups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants