Skip to content

Conversation

interc0der
Copy link
Contributor

Add Joey Wallet (and others) to Application Docs

  • Added Joey Wallet as an available wallet option for developers. General details (and link to documentation) are provided.

  • Added similar information for other missing wallet.

Context of Change

This is a small change to the README files. It has no impact on the functionality of the packages herein.

Type of Change

  • Documentation Updates

Did you update HISTORY.md?

  • No, this change does not impact library users

Test Plan

Copy link
Contributor

coderabbitai bot commented Sep 16, 2025

Walkthrough

Documentation update to APPLICATIONS.md: added entries for Joey Wallet and Crossmark Wallet under Wallets and wallet tools, adjusted GemWallet formatting by removing its bullet and leaving its description as a standalone paragraph. No code or API changes.

Changes

Cohort / File(s) Summary
Docs: Wallet entries update
APPLICATIONS.md
Added Joey Wallet and Crossmark Wallet entries with links and descriptions; reformatted GemWallet by removing its bullet, leaving its description as an indented paragraph; no functional/code changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A bunny taps the docs with care,
New wallets hop into the lair.
Joey, Crossmark, paths aligned,
Gem lines nudged, neatly refined.
Ears up high, I stamp and cheer—
Content updated, crystal clear! 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "chore: add joey wallet, and other missing wallets to applications doc" accurately summarizes the primary change — adding Joey Wallet and additional wallet entries to the applications documentation. It is concise, directly related to the changes in APPLICATIONS.md, and uses an appropriate "chore" prefix. The title is specific enough for a teammate scanning history to understand the main change.
Description Check ✅ Passed The PR description provides a clear high-level summary of the added wallets and states the change is documentation-only. It marks the Type of Change as Documentation Updates and correctly indicates HISTORY.md is not impacted. The Context of Change is brief and the Test Plan is empty, which is acceptable for a docs-only update, so the description is mostly complete relative to the repository template.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
APPLICATIONS.md (2)

83-83: Prefer descriptive link text over raw URLs.

Improves readability and accessibility.

Apply this diff:

-  Joey Wallet is a secure, self-custody cryptocurrency wallet and gateway to Web3 decentralized applications (dApps) on the XRP Ledger (XRPL). Documentation and integration details are located at [https://docs.joeywallet.xyz/](https://docs.joeywallet.xyz).
+  Joey Wallet is a secure, self-custody cryptocurrency wallet and gateway to Web3 decentralized applications (dApps) on the XRP Ledger (XRPL). Documentation: [Joey Wallet Docs](https://docs.joeywallet.xyz).

-  Crossmark is a browser-first, self-custodial wallet built for interacting with the XRP Ledger. Send, receive, create value with ease. Documentation can be found at [https://docs.crossmark.io/](https://docs.crossmark.io/).
+  Crossmark is a browser-first, self-custodial wallet for interacting with the XRP Ledger. Documentation: [Crossmark Docs](https://docs.crossmark.io/).

Also applies to: 87-87


81-88: Optional: consider alphabetical ordering within the Wallets list.

If the section intends alphabetical order, place “Crossmark” and “Joey Wallet” accordingly.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0608433 and 1c1a36e.

📒 Files selected for processing (1)
  • APPLICATIONS.md (1 hunks)
🔇 Additional comments (2)
APPLICATIONS.md (2)

81-88: Additions look good.

Joey Wallet and Crossmark entries are clear and match the section’s formatting.


81-88: Confirm inclusion criteria (uses xrpl.js) — Crossmark verified; Joey Wallet unverified

  • Crossmark — docs explicitly expose a lightweight xrpl.js on window.xrpl and include usage examples (keep).
  • Joey Wallet — public developer docs reference WalletConnect / wc-client; no xrpl.js references found. Provide a source showing Joey Wallet uses xrpl.js or remove/flag the Joey Wallet entry in APPLICATIONS.md (lines 81–88).

@Patel-Raj11
Copy link
Collaborator

@interc0der Hi, All the commits must be signed for this PR to get merged. Can you sign the commits and then we are good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants