-
Notifications
You must be signed in to change notification settings - Fork 559
chore: add joey wallet, and other missing wallets to applications doc #3082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughDocumentation update to APPLICATIONS.md: added entries for Joey Wallet and Crossmark Wallet under Wallets and wallet tools, adjusted GemWallet formatting by removing its bullet and leaving its description as a standalone paragraph. No code or API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
APPLICATIONS.md (2)
83-83
: Prefer descriptive link text over raw URLs.Improves readability and accessibility.
Apply this diff:
- Joey Wallet is a secure, self-custody cryptocurrency wallet and gateway to Web3 decentralized applications (dApps) on the XRP Ledger (XRPL). Documentation and integration details are located at [https://docs.joeywallet.xyz/](https://docs.joeywallet.xyz). + Joey Wallet is a secure, self-custody cryptocurrency wallet and gateway to Web3 decentralized applications (dApps) on the XRP Ledger (XRPL). Documentation: [Joey Wallet Docs](https://docs.joeywallet.xyz). - Crossmark is a browser-first, self-custodial wallet built for interacting with the XRP Ledger. Send, receive, create value with ease. Documentation can be found at [https://docs.crossmark.io/](https://docs.crossmark.io/). + Crossmark is a browser-first, self-custodial wallet for interacting with the XRP Ledger. Documentation: [Crossmark Docs](https://docs.crossmark.io/).Also applies to: 87-87
81-88
: Optional: consider alphabetical ordering within the Wallets list.If the section intends alphabetical order, place “Crossmark” and “Joey Wallet” accordingly.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
APPLICATIONS.md
(1 hunks)
🔇 Additional comments (2)
APPLICATIONS.md (2)
81-88
: Additions look good.Joey Wallet and Crossmark entries are clear and match the section’s formatting.
81-88
: Confirm inclusion criteria (uses xrpl.js) — Crossmark verified; Joey Wallet unverified
- Crossmark — docs explicitly expose a lightweight xrpl.js on window.xrpl and include usage examples (keep).
- Joey Wallet — public developer docs reference WalletConnect / wc-client; no xrpl.js references found. Provide a source showing Joey Wallet uses xrpl.js or remove/flag the Joey Wallet entry in APPLICATIONS.md (lines 81–88).
@interc0der Hi, All the commits must be signed for this PR to get merged. Can you sign the commits and then we are good to merge. |
Add Joey Wallet (and others) to Application Docs
Added Joey Wallet as an available wallet option for developers. General details (and link to documentation) are provided.
Added similar information for other missing wallet.
Context of Change
This is a small change to the README files. It has no impact on the functionality of the packages herein.
Type of Change
Did you update HISTORY.md?
Test Plan