-
Notifications
You must be signed in to change notification settings - Fork 1
fix: 내서재와 독서기록 기본정렬을 수정합니다. #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Walkthrough내서재(책)와 독서기록 조회의 기본 정렬 기준을 createdAt에서 updatedAt으로 변경. 독서기록 정렬 타입 enum에 UPDATED_DATE_ASC/DESC 추가. JPA Querydsl 리포지토리에서 기본/명시적 정렬에 updatedAt 기준 처리를 반영. 공개 API 시그니처 변화 없음. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor U as User
participant C as Controller
participant S as Service
participant R as Repository
U->>C: GET /reading-records (sort 미지정)
note right of C: Pageable 기본 정렬: updatedAt DESC
C->>S: findReadingRecords(pageable: sort=updatedAt DESC)
S->>R: query(sort=updatedAt DESC)
R-->>S: Page<ReadingRecord>
S-->>C: ReadingRecordPageResponse
C-->>U: 200 OK (updatedAt DESC)
U->>C: GET /reading-records?sort=UPDATED_DATE_ASC
C->>S: findReadingRecords(sort=UPDATED_DATE_ASC)
S->>R: query(sort=updatedAt ASC)
R-->>S: Page<ReadingRecord>
S-->>C: ReadingRecordPageResponse
C-->>U: 200 OK (updatedAt ASC)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (4)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
move-hoon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!



🔗 관련 이슈
📘 작업 유형
📙 작업 내역
createdAt→updatedAt로 수정createdAt→updatedAt로 수정UPDATED_DATE_ASC/UPDATED_DATE_DESC추가🧪 테스트 내역
✅ PR 체크리스트
💬 추가 설명 or 리뷰 포인트
Summary by CodeRabbit