Skip to content

[Added] Loud Subwoffer for Tuning Meet #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CSY0N wants to merge 9 commits into from
Closed

[Added] Loud Subwoffer for Tuning Meet #609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0695684
Create BigLoudSubwoofer.cpp
CSY0N Jul 4, 2025
4d35fea
Update Vehicle.cpp
CSY0N Jul 4, 2025
64b149a
Update Vehicle.cpp
CSY0N Jul 4, 2025
0d78c65
Merge branch 'YimMenu:enhanced' into enhanced
CSY0N Jul 18, 2025
7159e78
Merge branch 'YimMenu:enhanced' into enhanced
CSY0N Jul 30, 2025
c7d3e33
Update Pointers.cpp
CSY0N Aug 13, 2025
899ff60
Update Pointers.cpp
CSY0N Aug 14, 2025
ca86530
Updated to b889.22 Updated Pattern
CSY0N Aug 14, 2025
d457208
Merge branch 'YimMenu:enhanced' into enhanced
CSY0N Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions src/game/features/vehicle/BigLoudSubwoofer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
#include "core/commands/LoopedCommand.hpp"
#include "game/backend/Self.hpp"
#include "game/gta/Natives.hpp"
#include "game/gta/Pools.hpp"

namespace YimMenu::Features
{
class AllVehsLoudRadio : public LoopedCommand
{
using LoopedCommand::LoopedCommand;

virtual void OnTick() override
{
for (auto veh : Pools::GetVehicles())
{
Copy link
Collaborator

@maybegreat48 maybegreat48 Jul 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we enabling it for all vehicles?

Copy link
Contributor

@xesdoog xesdoog Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be OnTick either. This only works accidentally because he's looping it. Setting the engine on at the end makes no sense, it should be at the top with a short yield but still, there's no need for all of that. All he needs to do is call SET_VEHICLE_RADIO_LOUD on the player's vehicle only once on enable. If he wants it to persist when the player changes vehicles then he will have to manually track it by adding a member Vehicle::m_HasLoudRadio.

veh.ForceControl();
auto handle = veh.GetHandle();
auto target_veh = Vehicle(handle);
if (target_veh.RequestControl())
AUDIO::SET_VEHICLE_RADIO_ENABLED(handle, 1);
AUDIO::SET_VEHICLE_RADIO_LOUD(handle, 1);
VEHICLE::SET_VEHICLE_ENGINE_ON(handle, 1, 1, 0);
}
return;
}
};

static AllVehsLoudRadio _AllVehsLoudRadio{"loudsubwoffer", "Subwoofer", "Enables loud radio on vehicles, Players can hear it."};
}
5 changes: 3 additions & 2 deletions src/game/frontend/submenus/Vehicle.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ namespace YimMenu::Submenus
{
Vehicle::Vehicle() :
#define ICON_FA_CAR "\xef\x86\xb9"
Submenu::Submenu("Vehicle", ICON_FA_CAR)
Submenu::Submenu("Vehicle", ICON_FA_CAR)
{
auto main = std::make_shared<Category>("Main");

Expand All @@ -32,6 +32,7 @@ namespace YimMenu::Submenus

misc->AddItem(std::make_shared<BoolCommandItem>("speedometer"_J));
misc->AddItem(std::make_shared<BoolCommandItem>("seatbelt"_J));
misc->AddItem(std::make_shared<BoolCommandItem>("loudsubwoffer"_J));
misc->AddItem(std::make_shared<BoolCommandItem>("lowervehiclestance"_J, "Lower Stance"));
misc->AddItem(std::make_shared<BoolCommandItem>("allowhatsinvehicles"_J));
misc->AddItem(std::make_shared<BoolCommandItem>("lsccustomsbypass"_J));
Expand All @@ -46,4 +47,4 @@ namespace YimMenu::Submenus
AddCategory(BuildVehicleEditorMenu());
AddCategory(BuildSavedVehiclesMenu());
}
}
}
2 changes: 1 addition & 1 deletion src/game/pointers/Pointers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,4 +509,4 @@ namespace YimMenu
PatternCache::Update();
return true;
}
}
}