Skip to content

Conversation

@masoudgolchin
Copy link

Previously the check used initialPostTypeValues.length > 1. Since initial() drops the last item, this effectively required ≥3 post types before switching to the multi-type message. This change uses >= 1 so that two post types correctly trigger the multi-type message.

File: packages/js/src/settings/routes/templates/taxonomy.js No built assets committed.

Context

  • Fixes the taxonomy settings message so it lists multiple connected post types when there are two or more.

Summary

This PR can be summarized in the following changelog entry:

  • Selection condition changed from initialPostTypeValues.length > 1 to >= 1.
  • Rationale: initial() excludes the last element, so the previous condition only switched to the multi-type string when there were at least 3 post types.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Create another custom post-type called "Podcasts"
  • Assign the default "category" taxonomy to this new post-type. In a way that it is shared between "Post" and "Podcasts" post-types/
  • Go to Yoast Settings > Categories & Tags > Select Categories
  • In the header it says: "This taxonomy is used for Podcasts." but in fact it should say "This taxonomy is used for Posts and Podcasts."

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • [x ] I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • [x ] I have written this PR in accordance with my team's definition of done.
  • [x ] I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

Previously the check used initialPostTypeValues.length > 1.
Since initial() drops the last item, this effectively required ≥3 post types
before switching to the multi-type message. This change uses >= 1 so that two
post types correctly trigger the multi-type message.

File: packages/js/src/settings/routes/templates/taxonomy.js
No built assets committed.
@masoudgolchin
Copy link
Author

masoudgolchin commented Oct 2, 2025

Before:

image

After:

Screenshot 2025-10-02 at 10 33 54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants