STAT: Add parameterised cells #5281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suisseWalter
changed the title
KrystalDelusion
requested changes
Aug 12, 2025
There was a problem hiding this comment.
As with #5054, it would be good to add a test or two for the behavior you're adding, along with minimal versions of the .lib files you've got in the PR description that can be included in the repository (containing just a couple cell types to check a small design).
added 3 commits
August 13, 2025 08:36
fix design hierarchy containing wrong values. remove left over debug print.
Fix some unknown cells apearing twice.
Fix existing testcases Fix edgecase where modules where counted as cells.
suisseWalter
force-pushed
the
add_parameterised_cells_stat
branch
from
efe4fcd to
bf876cd
Compare
|
Testcases have been added. |
Co-authored-by: KrystalDelusion <[email protected]>
cells can have their area as a function of the input port width.
Should be covered by the yosys license not anything else.
suisseWalter
force-pushed
the
add_parameterised_cells_stat
branch
from
fd46d7b to
9278bed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS PR IS A EXTENSION OF #5054 . (I'm not sure how this should be presented best, should it just contain the changes after #5054? currently it is a branch of the #5054 branch)
What are the reasons/motivation for this change?
In discussion with @phsauter and the PULP group there is a need to have a way to estimate the area earlier in the flow.
This PR implements a way to estimate the area earlier in the flow. It allows for lib files that have been customised to contain tables to lookup the "area" by the size of the input/output of the cells. This is the same idea as for #5278 .
The details are explained there.
Explain how this is achieved.
See the same idea as #5278.
The user can use their own definition of area.
There is a prepared lib files for area estimated using nand2 gates as equivalent. and then just using mathematical scaling.
If applicable, please suggest to reviewers how they can test the change.
There are these three lib files as a example (the first one could also be replaced by a actual lib file from a pdk)
they can be loaded and should be usable with any design. I have used the croc design from pulp.
These are the same files as used by #5278.
IHP130 standard cells: ihp130_stdcell.lib.txt
Yosys internal cells (which are used after techmap): nand2_based_internal.lib.txt
Yosys internal cells (before techmap): area_by_width.lib.txt