Skip to content

Use translation key instead of config for navigation group #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use translation key instead of config for navigation group #143

wants to merge 1 commit into from
+5 −0

Conversation

@RawanD201
Copy link

feat: replace config-based navigation group with translation key

  • Use __('filament-logger::filament-logger.nav.group') instead of config lookup
  • Improves multi-language support following Laravel conventions
  • Maintains backward compatibility with existing translations

aspirantzhang
aspirantzhang approved these changes Aug 10, 2025
View reviewed changes
Copy link

@aspirantzhang aspirantzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I recommend merging this PR.

@aspirantzhang
Copy link

@RawanD201
#146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@aspirantzhang aspirantzhang aspirantzhang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RawanD201 @aspirantzhang