-
-
Couldn't load subscription status.
- Fork 44
Add Windows support #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thank you for taking the time to send this PR @Gaweringo. I imagine some Windows users might prefer this approach over WSL, specially when trying the plugin for the first time. Please give me this week to review it. In the mean time if you want, you can check if the tests pass on windows running this command inside of Neovim: |
|
I ran the test files for the languages I changed.
|
This PR would make all commands which use
rm -fandmkdir -pwindows compatible by adding theget_commands()function toutilswhich swaps the unix commands with the cmd commandserase /s /qandmkdir.The way to ignore errors is also different and is changed from
|| trueto> nul 2> nul & cd.for cmd. Ignoring errors is also needed formkdirin cmd, since there is no-pequivalent.I could not test the
asmchanges fully yet, since it uses linux/unix syscalls from what I understand. Building and linking works, but the "Run program" does not succeed and exits with a large negative exit code.Languages which had changes:
Bau which had changes:
From my testing, everything should still work on Linux with these changes.
Let me know if I need to change something, or if this PR might go in the wrong direction / uses an undesired approach.