Skip to content

Aviron: Support multiple MCUs #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2025
Merged

Aviron: Support multiple MCUs #683

merged 1 commit into from
Oct 26, 2025

Conversation

@Grazfather
Copy link
Collaborator

@Grazfather Grazfather commented Sep 24, 2025 •
edited
Loading

  • Add support for selecting MCU on command line
    • This is currently done by using a comptime arg for the config, sidestepping the need to support a dynamic bus type.
  • Add support for tests to run on multiple MCUs

@Grazfather Grazfather requested a review from ikskuh September 24, 2025 08:42
Grazfather
Grazfather commented Sep 24, 2025
View reviewed changes
Grazfather
Grazfather commented Sep 24, 2025
View reviewed changes
Grazfather
Grazfather commented Sep 24, 2025
View reviewed changes
@Grazfather Grazfather marked this pull request as ready for review September 26, 2025 12:53
@Grazfather Grazfather marked this pull request as draft September 26, 2025 16:03
@Grazfather Grazfather changed the base branch from aviron_fixes to main September 27, 2025 11:53
@Grazfather Grazfather marked this pull request as ready for review September 27, 2025 12:16
Grazfather
Grazfather commented Sep 27, 2025
View reviewed changes
ikskuh
ikskuh requested changes Oct 2, 2025
View reviewed changes
Copy link
Contributor

@ikskuh ikskuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the main pain point is that we should introduce a proper memory mapper instead of doing all of these workarounds, as it will actually simplify the code a lot

@Grazfather Grazfather force-pushed the aviron_features branch 2 times, most recently from 5240640 to fd54e9b Compare October 3, 2025 00:09
Grazfather
Grazfather commented Oct 4, 2025
View reviewed changes
@Grazfather Grazfather force-pushed the aviron_features branch 4 times, most recently from c1a82cf to 0608119 Compare October 5, 2025 14:40
@Grazfather Grazfather mentioned this pull request Oct 16, 2025
Merged
@Grazfather Grazfather force-pushed the aviron_features branch 2 times, most recently from 206a54a to de80209 Compare October 24, 2025 14:22
Grazfather
Grazfather commented Oct 24, 2025
View reviewed changes
sim/aviron/src/main.zig

fn run_with_mcu(
allocator: std.mem.Allocator,
comptime mcu_config: anytype,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach bloats the binary size but avoids needing a dynamically sized bus

@Grazfather Grazfather requested a review from ikskuh October 24, 2025 14:28
@Grazfather Grazfather force-pushed the aviron_features branch 3 times, most recently from d2e6407 to b20c085 Compare October 25, 2025 23:17
@Grazfather Grazfather changed the title Aviron features Aviron: Support multiple MCUs Oct 25, 2025
@mattnite mattnite merged commit ef42935 into main Oct 26, 2025
49 checks passed
@mattnite mattnite deleted the aviron_features branch October 26, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ikskuh ikskuh Awaiting requested review from ikskuh

Assignees

No one assigned

Labels

aviron

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Grazfather @ikskuh @mattnite