rp2040 pio: Fix absolute addressing of jmp and wrap #700
Conversation
When assembled the jmp and wrap/wrap_target are relative to the start of the program. When added into instruction memory the addresses they point to have to be offset.
|
@mattnite, |
|
It would be fantastic if you added a test problem that demonstrated the issue and the fix. |
|
@Grazfather |
|
Just in the PR title because that’ll be the commit title after the squash
by default
Thanks,
G
…On Tue, Oct 7, 2025 at 7:11 PM Kytezign ***@***.***> wrote:
*Kytezign* left a comment (ZigEmbeddedGroup/microzig#700)
<#700 (comment)>
@Grazfather <https://github.com/Grazfather>
You mean in the commit? Or are you just looking for more details about the
issue in the comments?
—
Reply to this email directly, view it on GitHub
<#700 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADZNHSQDKMY5IIDPR25SBD3WRCBLAVCNFSM6AAAAACIHRCJ6SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGNZYHE4TSNBRGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Kytezign
changed the title
|
I updated the title to give some indication of the problem and how this fixes it. |
Grazfather
changed the title
|
I actually mixed up which PR I was replying to (I was on my phone). In #702 I would like for you to explain the update better in the title because when merged it'll be easier to spot what you are updating and why via commit history. |
|
@Grazfather |
|
Yeah my mistake! that's what I get for commenting via email. |
|
It looks good to me but I will let Matt give final approval. |
|
Not sure what if anything needs to be done about this, but my changes here are solving a subset of the problems addressed by #633 in a slightly different (simpler?) way. |
3 participants
When assembled the jmp and wrap/wrap_target are relative to the start of the program. When added into instruction memory the addresses they point to have to be offset.
Fixed by adding the program offset when loading the program into the pio memory. Without this, jmp and wrap could point to a different program (the first one loaded)