fix: Make onSendMessage() handling less aggressive

[kabir]

Record the failure in the Task, unless it is in a final state, and return the Task to the user like before the last change.

Upstream #447

[gemini-code-assist]

Summary of Changes

Hello @kabir, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the error handling mechanism within the onSendMessage() method to be less disruptive. Instead of abruptly terminating execution with an InternalError upon encountering issues like timeouts or execution exceptions, the system now captures these failures and records them directly within the associated Task object. This approach ensures that the task's state accurately reflects any problems, providing clearer feedback and allowing the task to be returned to the user with its updated status, thereby improving overall system robustness and diagnostic capabilities.

Highlights

• Refined Error Handling: Modified the onSendMessage() method to handle exceptions more gracefully by capturing failure states rather than immediately throwing InternalError.
• Task Failure Recording: Failures encountered during task processing (e.g., InterruptedException, ExecutionException, TimeoutException) are now recorded directly within the Task object.
• Conditional Task State Update: The Task status is updated to FAILED with a detailed error message only if an exception occurred and the task is not already in a final state.
• Improved User Feedback: Ensures that the Task object, even if failed, is returned to the user, providing more context about the failure.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the error handling in onMessageSend to be less aggressive. Instead of throwing an InternalError when waiting for task completion times out or fails, it now records the failure in the Task object itself by setting its state to FAILED and returns the updated task. This is a good improvement as it provides more context to the caller about the failure.

My review includes one suggestion to further improve the robustness of this new error handling logic by considering an edge case where the task might not be present in the taskStore when a failure occurs.