Fine-tune the Ordering for nbars #122
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still need
Releasehere to make sure our write oflinesandnlineshappens before this, and we don't needAcquirehere since there are no modifications we need to make visible to other thread.pb/src/multi.rs
Lines 160 to 163 in d60b964
The
loadat 210 should useAcquireto synchronize with the store oflinesandnlines, which are read at 220 and 224. TheCASoperation at 214 can beRelaxedsince, at this point, themessagehas done its job. Thus, this operation does not provide synchronization, only atomicity.pb/src/multi.rs
Lines 210 to 234 in d60b964