[혜원] 4-ExchangeRate #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leehyewon0531
requested review from
11t518s,
SaaaHoP,
chaeiJeon,
dltkdals224 and
yoon-junseo
chaeiJeon
reviewed
Apr 3, 2022
| const firstCountry = $firstSelect.options[$firstSelect.selectedIndex].value | ||
| const secondCountry = $secondSelect.options[$secondSelect.selectedIndex].value | ||
|
|
||
| fetch("https://v6.exchangerate-api.com/v6/0c8fbd2c3ca43caf99612cff/latest/USD") |
Contributor
There was a problem hiding this comment.
/latest/${firstCountry} 로 데이터를 불러와서 사용하면 16번 줄에서
(response.conversion_rates[secondCountry]) / (response.conversion_rates[firstCountry]) 를 response.conversion_rates[secondCountry] 이렇게 줄일 수 있을 것 같아요!
| const secIndex = $secondSelect.selectedIndex | ||
| $firstSelect.options[secIndex].selected = true | ||
| $secondSelect.options[firIndex].selected = true | ||
| [$firstSelect, $secondSelect] = [$secondSelect, $firstSelect] |
Contributor
There was a problem hiding this comment.
임시 값 없이 바로 교환 할 수 있어서 좋은 것 같아요!
yoon-junseo
reviewed
Apr 5, 2022
| const secIndex = $secondSelect.selectedIndex | ||
| $firstSelect.options[secIndex].selected = true | ||
| $secondSelect.options[firIndex].selected = true | ||
| [$firstSelect, $secondSelect] = [$secondSelect, $firstSelect] |
Contributor
There was a problem hiding this comment.
임시 값 없이 바로 교환 할 수 있어서 좋은 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.