Skip to content

Enable Minimap2 compilation on ARM64 platforms #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
megawron wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enable Minimap2 compilation on ARM64 platforms #284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions quast_libs/qutils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
import shutil
import subprocess
import os
import platform
import stat
import sys
import re
Expand Down Expand Up @@ -892,10 +893,18 @@ def compile_tool(name, dirpath, requirements, just_notice=False, logger=logger,
call_subprocess(['./configure'] + configure_args, stdout=open(make_logs_basepath + '.log', 'a'),
stderr=open(make_logs_basepath + '.err', 'a'))
os.chdir(prev_dir)

current_make_command_parts = (['make', make_cmd] if make_cmd else ['make'])
if name == 'Minimap2' and (platform.machine() == 'arm64' or platform.machine() == 'aarch64'):
logger.main_info(f'Detected 64-bit ARM ({platform.machine()}). Applying ARM-specific make flags for Minimap2.')
current_make_command_parts.extend(['arm_neon=1', 'aarch64=1'])

final_make_command_for_subprocess = current_make_command_parts + ['-C', dirpath]

try:
return_code = call_subprocess((['make', make_cmd] if make_cmd else ['make']) + ['-C', dirpath],
stdout=open(make_logs_basepath + '.log', 'a'),
stderr=open(make_logs_basepath + '.err', 'a'), logger=logger)
return_code = call_subprocess(final_make_command_for_subprocess,
stdout=open(make_logs_basepath + '.log', 'a'),
stderr=open(make_logs_basepath + '.err', 'a'), logger=logger)
except IOError:
msg = 'Permission denied accessing ' + dirpath + '. Did you forget sudo?'
if just_notice:
Expand Down