Skip to content

fix regex related parsing route name #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+1 −1
Closed

fix regex related parsing route name #1284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/schema-routes/schema-routes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ export class SchemaRoutes {

// TODO forbid leading symbols [\]^` in a major release (allowed yet for backwards compatibility)
const pathParamMatches = (routeName || "").match(
/({[\w[\\\]^`][-_.\w]*})|(:[\w[\\\]^`][-_.\w]*:?)/g,
/(?<=\/|\.\.\.)({[\w[\\\]^`][-_.\w]*})|(?<=\/|\.\.\.)(:[\w[\\\]^`][-_.\w]*:?)/g,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Regex Lookbehind Compatibility Issue

The regex in parseRouteName now uses positive lookbehind assertions. As an ES2018 feature, these cause a SyntaxError in older JavaScript environments (e.g., Safari <16.4, Firefox <78, Node.js <8.10), which breaks route parsing functionality.

Fix in Cursor Fix in Web

);

// used in case when path parameters is not declared in requestInfo.parameters ("in": "path")
Expand Down