navicon: Use span instead of div inside button element #3356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally all generated pages have the following error in HTML validator (e.g., https://validator.w3.org/nu/): Element div not allowed as child of element button in this context. (Suppressing further errors from this subtree.) From line 1, column 2805; to line 1, column 2825 > <button><div class="navicon"></div> We replace <div> with <span>, and also set display: inline-block to fix this validation error and not to alter the existing visual layout.
hosiet
force-pushed
the
pr-fix-html-validation-div-in-button
branch
from
ca7f589 to
971972b
Compare
Collaborator
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally all generated pages have the following error in HTML validator (e.g., https://validator.w3.org/nu/):
We replace
<div>with<span>, and also setdisplay: inline-blockto fix this validation error and not to alter the existing visual layout.