Refactor/use babel 6 #269
Refactor/use babel 6 #269
Conversation
|
CC @mjrussell |
| 'or a class/function (for composite components) but got: object. ' + | ||
| 'Check the render method of `ReduxRouterContext`.'; | ||
|
|
||
| const routingContextInvalidPropErrorMessage = 'Invalid prop `RoutingContext` of type `object` supplied to `ReduxRouterContext`'; |
There was a problem hiding this comment.
@halt-hammerzeit I had to remove this error message after the babel6 update. Could you take look?
There was a problem hiding this comment.
@Scarysize don't know why is that. if you redid npm install then maybe React got updated to 15.3
https://twitter.com/reactjs/status/759099486513704961
There was a problem hiding this comment.
No npm ls | grep react shows me [email protected]. Seems to be the correct minor version.
There was a problem hiding this comment.
@Scarysize So what is the error message now?
There was a problem hiding this comment.
Basically the two other Strings the test checks for.
There was a problem hiding this comment.
@Scarysize I meant what was the error message in your terminal when running tests before you removed the lines
There was a problem hiding this comment.
AssertionError: expected 'Warning: Failed propType: Invalid prop `RoutingContext` of type `object` supplied to `Connect(ReduxRouterContext)`, expected `function`. Check the render method of `ReduxRouter`.' to include 'Invalid prop `RoutingContext` of type `object` supplied to `ReduxRouterContext`'
There was a problem hiding this comment.
@Scarysize Well then why do you ask me in the first place and also delete the test line when it tells you in plain English what needs to be corrected.
There was a problem hiding this comment.
I wanted your opinion on the matter, because you added the test. I don't want to blindly remove stuff from tests, just to make them pass.
Sorry to waste your precious time 😒
2 participants
No description provided.