Skip to content

[i18n/meta] Update Makefile to only compile changed language files #10076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[i18n/meta] Update Makefile to only compile changed language files #10076

wants to merge 3 commits into from

Conversation

@driusan
Copy link
Collaborator

@driusan driusan commented Oct 30, 2025

Some tweaks to the Makefile language file generation:

  1. Only run msgfmt or i18next-conv if the original .po file has changed
  2. Ensure make modulename handles file generation the same way as make locales
  3. Consistently generate the json files for all .po files, instead of doing it selectively as we need it.

@driusan driusan added the State: Needs work PR awaiting additional work by the author to proceed label Oct 31, 2025
@driusan
Copy link
Collaborator Author

driusan commented Oct 31, 2025

Need to rebase this and add any missing new .po files to the list.

@driusan driusan force-pushed the BetterLangMakefile branch from ae2d2b4 to 4c67158 Compare October 31, 2025 18:46
@driusan driusan removed the State: Needs work PR awaiting additional work by the author to proceed label Oct 31, 2025
@kongtiaowang kongtiaowang self-assigned this Nov 10, 2025
@kongtiaowang kongtiaowang added the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Nov 19, 2025
@driusan driusan removed the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Nov 24, 2025
Dave MacFarlane added 3 commits November 27, 2025 16:11
[i18n/meta] Update Makefile to only compile changed language files
e3e4037 
This updates the makefile so that it will only run the msgfmt or i18next-conv
commands if the source file has changed. This should speed up compile time
during development.
Use filter to generate dependency list
c9e1165
Update po file list
e1b166d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kongtiaowang kongtiaowang

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@driusan @kongtiaowang