Skip to content

Conversation

@kongtiaowang
Copy link
Contributor

Incorrect login_summary_statistics table name in LORIS 27 SQL patch #10095

@github-actions github-actions bot added the Language: SQL PR or issue that update SQL code label Nov 7, 2025
@kongtiaowang kongtiaowang changed the title [SQL]Incorrect login_summary_statistics table name in LORIS 27 SQL patch #10095 [SQL]Incorrect login_summary_statistics table name in LORIS 27 SQL patch - 27.0-release Nov 7, 2025
@github-actions github-actions bot added the Language: PHP PR or issue that update PHP code label Nov 10, 2025
Copy link
Contributor

@MaximeBICMTL MaximeBICMTL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as #10097. LGTM.

@github-actions github-actions bot added the RaisinBread PR or issue introducing/requiring improvements to the Raidinbread dataset label Nov 25, 2025
@github-actions github-actions bot added the Module: login PR or issue related to login module label Nov 25, 2025
@MaximeBICMTL
Copy link
Contributor

MaximeBICMTL commented Nov 25, 2025

Not sure why you changed the table name to Login_Summary_Statistics (uppercase), I had approved the PR, and the lowercase version is more consistent with the LORIS SQL schema.

If you needed a merge after review, just tag Dave here or on Slack IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language: PHP PR or issue that update PHP code Language: SQL PR or issue that update SQL code Module: login PR or issue related to login module RaisinBread PR or issue introducing/requiring improvements to the Raidinbread dataset

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants