-
-
Notifications
You must be signed in to change notification settings - Fork 33
Use uv with pyproject.toml file to lock version used. #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
VoXoXoX
wants to merge
1
commit into
ack00gar:v0.5.0
Choose a base branch
from
VoXoXoX:use_uv
base: v0.5.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VoXoXoX
commented
Jul 23, 2025
|
I only test it on Linux. A test on Windows could be better to confirm if it works too |
|
Thanks again, I will test it on Mac when I can :) |
Rakly3
reviewed
Jul 25, 2025
Rakly3
reviewed
Jul 25, 2025
Rakly3
reviewed
Jul 25, 2025
Rakly3
reviewed
Jul 25, 2025
|
By the way, I choose UV instead of poetry because poetry doesn't support easily the installation for pytorch for different source (cuda, cuda-rtx, rocm) |
4eb0693 to
9b9b6ab
Compare
It can avoid issue when there are package updates and guarantee everyone will have the same package versions (too many issue happen with requirements files) "uv lock --upgrade" can be used to upgrade the dependencies Easy usage to install package for all cases: - uv sync --extra cpu - uv sync --extra cuda - uv sync --extra cuda-rtx50 - uv sync --extra rocm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can avoid issue when there are package updates and guarantee everyone will have the same package versions (too many issue happen with requirements files) "uv lock --upgrade" can be used to upgrade the dependencies
Easy usage to install package for all cases: