Gutlapallin/prof animation #94
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ALE00111
requested changes
Aug 10, 2025
| import Image from "next/image"; | ||
| import professorImage from "@/public/about/watkinsonMedina.webp"; | ||
|
|
||
| import { motion } from "motion/react"; |
There was a problem hiding this comment.
minor, but can you put all the imports together at the top
| transition={{ duration: 2.5 }} | ||
| viewport={{ once: true }} | ||
| > | ||
| <div className="w-full xl:w-4/5"> |
There was a problem hiding this comment.
I don't think this div is needed anymore, but you can combine it with the above motion.div and readjust the width's and stuff need be
| <motion.div | ||
| initial={{ opacity: 0 }} | ||
| whileInView={{ opacity: 1 }} | ||
| transition={{ duration: 2.5 }} |
| <motion.div | ||
| initial={{ opacity: 0 }} | ||
| whileInView={{ opacity: 1 }} | ||
| transition={{ duration: 2.5 }} |
| </p> | ||
| </div> | ||
| <div className="mx-8 mb-4 flex flex-row justify-center gap-8 xl:flex-row xl:items-center"> | ||
| <motion.div |
There was a problem hiding this comment.
both these motion.div tags are the same, you can either make a custom animation component at the top of this file and call it whenever it's needed, or try to make this animation in the div above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.