-
Couldn't load subscription status.
- Fork 0
Achievements Grid #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good work, just a small comment. also can you revert the names of the files; it's better named as it helps us reference what each photo is without having to actually open it.
| import LeftAchCard from "./LeftAchCard"; | ||
| import RightAchCard from "./RightAchCard"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make these have absolute pathing with @. an example is like line 3 (import AchievementsData from "@/data/AchievementsData";)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!

For this issue, a lot of them have changed:
LeftAchandRightAchbecause we no longer need them. All data is stored inAchievementsData.tsand input card elementsLeftAchCardandRightAchCardtoAchievementsGrid.tsx.LeftAchCardandRightAchCard. And the grid size is even different. See image below:Also, since the mobile page is different, the Whole grid will be hidden,
hidden md:block.Since the web page is too long, I captured a full-size web preview (since the image is large when uploaded to GitHub, that ratio doesn't seem right. Switch to this branch to see the complete work).

close #47