Skip to content

Conversation

@XiyuanWu
Copy link
Collaborator

@XiyuanWu XiyuanWu commented Oct 23, 2025

For this issue, a lot of them have changed:

  1. Remove the test image; only keep the mock trail image. The naming is also messy; I rank and list them in order.
  2. Delete LeftAch and RightAch because we no longer need them. All data is stored in AchievementsData.ts and input card elements LeftAchCard and RightAchCard to AchievementsGrid.tsx.
  3. Different code style between LeftAchCard and RightAchCard. And the grid size is even different. See image below:
192 168 12 21_3000_achievements (1) So to address this issue, I replaced one of the Card elements entirely and adjusted the grid size, making sure they are in the same code style, the only difference is the order of the div box. Technically, both elements should be assigned to the same people, because they essentially just rearrange the div box in a different order. Left Ach image div box is on top, and Right Ach text div box is on top.

Also, since the mobile page is different, the Whole grid will be hidden, hidden md:block.

Since the web page is too long, I captured a full-size web preview (since the image is large when uploaded to GitHub, that ratio doesn't seem right. Switch to this branch to see the complete work).
192 168 12 21_3000_achievements

close #47

@XiyuanWu XiyuanWu requested a review from wesleylwu October 23, 2025 02:23
@XiyuanWu XiyuanWu self-assigned this Oct 23, 2025
Copy link
Contributor

@wesleylwu wesleylwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work, just a small comment. also can you revert the names of the files; it's better named as it helps us reference what each photo is without having to actually open it.

Comment on lines 1 to 2
import LeftAchCard from "./LeftAchCard";
import RightAchCard from "./RightAchCard";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make these have absolute pathing with @. an example is like line 3 (import AchievementsData from "@/data/AchievementsData";)

@XiyuanWu
Copy link
Collaborator Author

I try to replace it with @, but the import fails. Because they are under same folder, so use ./.
image

And with the image, the original image names are messy and very hard to do when adding to achievementsData. All the images follow the order that Figma gives.

Copy link
Contributor

@JeffreyXia05 JeffreyXia05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@JeffreyXia05 JeffreyXia05 merged commit 457ebaf into dev Oct 27, 2025
5 checks passed
@JeffreyXia05 JeffreyXia05 deleted the x/ach-map branch October 27, 2025 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Week 4: Achievements Mapping

3 participants