Add a class implementing DNS Discovery #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etcd supports using SRV records to help clients discover the etcd cluster: <https://coreos.com/etcd/docs/latest/v2/clustering.html#dns-discovery>. This implements a basic class to get a list of servers in the cluster, and a helper function to pick one in accordance with RFC 2782.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
etcd supports using SRV records to help clients discover the etcd
cluster:
https://coreos.com/etcd/docs/latest/v2/clustering.html#dns-discovery.
This implements a basic class to get a list of servers in the cluster,
and a helper function to pick one in accordance with RFC 2782.
I tried to follow the existing code style, but might have missed something. We are currently evaluating and planning to use etcd for configuring parts of MediaWiki on Wikimedia wikis, and one of our requirements is being able to discover individual etcd servers using the DNS discovery. And while this doesn't need to be part of this library, I think it would make a nice addition.