feat(framework): Add utility functions for reading global connection config #6240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panh99
commented
Dec 4, 2025
Comment on lines
+61
to
+69
| def get_flwr_home() -> Path: | ||
| """Get the Flower home directory path. | ||
| Returns FLWR_HOME environment variable if set, otherwise returns a default | ||
| subdirectory in the user's home directory. | ||
| """ | ||
| if flwr_home := os.getenv(FLWR_HOME): | ||
| return Path(flwr_home) | ||
| return Path.home() / FLWR_DIR |
Member
Author
There was a problem hiding this comment.
We also have a similar get_flwr_dir function. I wonder if we should merge this with it.
The original function is a bit unnecessarily complicated:
def get_flwr_dir(provided_path: str | None = None) -> Path:
"""Return the Flower home directory based on env variables."""
if provided_path is None or not Path(provided_path).is_dir():
return Path(
os.getenv(
FLWR_HOME,
Path(f"{os.getenv('XDG_DATA_HOME', os.getenv('HOME'))}") / FLWR_DIR,
)
)
return Path(provided_path).absolute()
github-actions
bot
added
the
Maintainer
jafermarq
reviewed
Dec 5, 2025
| class ConnectionConfigYamlKey: | ||
| """YAML keys for connection configuration.""" | ||
|
|
||
| CURRENT_CONNECTION = "current-connection" |
Member
There was a problem hiding this comment.
should we still include this in the v1?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.