Skip to content

feat: Support allowsEmptyCollection in Select component #8984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 20, 2025
Merged

feat: Support allowsEmptyCollection in Select component #8984

merged 3 commits into from
Oct 20, 2025
+5 −3

Conversation

vovsemenv
Copy link
Contributor

Closes #8701

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

reidbarber
reidbarber approved these changes Oct 20, 2025
View reviewed changes
Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!!

@LFDanLu LFDanLu changed the title Add allowsEmptyCollection prop in Select component feat: Support allowsEmptyCollection in Select component Oct 20, 2025
@LFDanLu LFDanLu added this pull request to the merge queue Oct 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 20, 2025
@vovsemenv
Copy link
Contributor Author

The merge check error message not clear about the problem

s2-build

- Building DisclosureGroup.css...

make[1]: *** [Makefile:158: build-s2-docs] Error 129
make[1]: Leaving directory '/home/circleci/react-spectrum'
make: *** [Makefile:149: s2-docs] Error 2

Exited with code exit status 2
``

@yihuiliao yihuiliao added this pull request to the merge queue Oct 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 20, 2025
@snowystinger snowystinger added this pull request to the merge queue Oct 20, 2025
Merged via the queue into adobe:main with commit f40b575 Oct 20, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbarber reidbarber reidbarber approved these changes

@LFDanLu LFDanLu LFDanLu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support allowsEmptyCollection prop in Select component

5 participants

@vovsemenv @reidbarber @LFDanLu @snowystinger @yihuiliao