Skip to content

Conversation

yihuiliao
Copy link
Member

@yihuiliao yihuiliao commented Oct 14, 2025

The way this works is that you have to give the cursor chat two files for context, one containing the release notes rules, and the other a file containing a list of the commits obtained by running our changelog script.

It's not perfect and will still require us to go through manually and fix things, but it's better than nothing!

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@yihuiliao yihuiliao marked this pull request as ready for review October 14, 2025 22:01
reidbarber
reidbarber previously approved these changes Oct 14, 2025
snowystinger
snowystinger previously approved these changes Oct 14, 2025
| feat | Enhancements|
| fix | Fixes |
| docs | Documentation |
| alpha, beta, rc | Under Construction
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I ran this locally, it classified the autocomplete changes as enhancements but probably should've been "under construction". Can we also include in these rules that Cursor should make an effort to scan the associated packages for a release tag?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i tried prompting it locally to do this and it seems to do better (moved the autocomplete changes to under construction and the XL dialog one to S2) so it might be possible even though it can't access the pulls directly?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay so...i tried my best to get it to scan for packages and their release tags but it really is a hit or miss. i've found that i have to prompt it again to look more carefully but at least i don't need to specify a specific component package

@yihuiliao yihuiliao dismissed stale reviews from snowystinger and reidbarber via 5a86d32 October 15, 2025 23:10
@yihuiliao
Copy link
Member Author

yihuiliao commented Oct 15, 2025

I ended up splitting up the rules since I found Cursor performs better with more targeted rules. When I had it all together in one file, sometimes it would leave out commits even when I specified to keep all of them.

It also allows us to make adjustments in between steps (like changing which commits go under which category). So yeah, you will have to run it minimum 3x but I think it produces better results.

@rspbot
Copy link

rspbot commented Oct 15, 2025

@rspbot
Copy link

rspbot commented Oct 15, 2025

@rspbot
Copy link

rspbot commented Oct 15, 2025

## API Changes

react-aria-components

/react-aria-components:GridListSectionProps

-GridListSectionProps <T> {
-  aria-label?: string
-  children?: ReactNode | (T) => ReactElement
-  className?: string = 'react-aria-GridListSection'
-  dependencies?: ReadonlyArray<any>
-  id?: Key
-  items?: Iterable<T>
-  style?: CSSProperties
-  value?: T
-}

@snowystinger
Copy link
Member

snowystinger commented Oct 15, 2025

Can we use the planning feature to assist with this? https://cursor.com/docs/agent/planning

@yihuiliao
Copy link
Member Author

Can we use the planning feature to assist with this? https://cursor.com/docs/agent/planning

ooo interesting, i'll take a look tomorrow

@yihuiliao
Copy link
Member Author

Ah okay, so the planning feature is kinda interesting because you have this conversation with the Agent to actually build a plan of execution which actually takes more time (?) because then you have to edit it, converse with it, etc. It does say you can save it to .cursor/plans but then when you click "build" it'll try to implement some code based on the steps which is not what I want it to do. I guess the Plan mode focuses more on gathering info and architecting a solution to then write some code, but again, not really what I'm looking for here.

Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work well, I think we'll just need to be cognizant that it might not catch everything, but we can pretty easily confirm that via comparing the count of commits classified vs the total number of commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants