Skip to content

Conversation

@yihuiliao
Copy link
Member

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Nov 4, 2025

@rspbot
Copy link

rspbot commented Nov 4, 2025

```

{/* ### Breakpoints */}
{/* TODO: Link to style macro docs about breakpoints */}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we wanting to include this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im fine to leave it out since it's covered by the styles guide but since we had a breakpoints section in the previous provider page for v3, people might be expecting it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can include it in the Migration guide and it should be covered by the style macros page as well

@yihuiliao yihuiliao added this pull request to the merge queue Nov 4, 2025
Merged via the queue into main with commit 5658d9d Nov 4, 2025
32 checks passed
@yihuiliao yihuiliao deleted the add-provider-docs branch November 4, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants