feat: add sandbox configuration update API #1230
Open
+3,971
−2,334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kanishkavijay39
force-pushed
the
SITES-sandbox-audit-configuration
branch
from
a34293f to
1958320
Compare
|
This PR will trigger a minor release when merged. |
Kanishkavijay39
force-pushed
the
SITES-sandbox-audit-configuration
branch
3 times, most recently
from
f31281e to
d07c146
Compare
- Add PATCH /configurations/sandbox endpoint for updating sandbox audit configurations - Implement updateSandboxConfig method in ConfigurationController with admin access control
Kanishkavijay39
force-pushed
the
SITES-sandbox-audit-configuration
branch
from
d07c146 to
2129b15
Compare
added 4 commits
September 8, 2025 22:34
- Add updateSandboxConfig method to configuration controller - Update sandbox audit configurations using spacecat-shared methods - Add comprehensive tests for all scenarios including success and error paths - Achieve 99.96% coverage (remaining 0.04% from pre-existing uncovered paths) - Fix function coverage by replacing arrow functions with method references
Kanishkavijay39
force-pushed
the
SITES-sandbox-audit-configuration
branch
from
01dea9f to
1356e41
Compare
Kanishkavijay39
force-pushed
the
SITES-sandbox-audit-configuration
branch
from
1356e41 to
28edfe3
Compare
Kanishkavijay39
force-pushed
the
SITES-sandbox-audit-configuration
branch
from
325943b to
615bef8
Compare
added 4 commits
September 11, 2025 00:18
…ss with hasSandboxAudits() method
Kanishkavijay39
commented
Sep 11, 2025
| "@adobe/spacecat-shared-athena-client": "1.3.0", | ||
| "@adobe/spacecat-shared-brand-client": "1.1.20", | ||
| "@adobe/spacecat-shared-data-access": "2.58.0", | ||
| "@adobe/spacecat-shared-data-access": "https://gitpkg.now.sh/adobe/spacecat-shared/packages/spacecat-shared-data-access?feature/site-sandbox-configuration", |
There was a problem hiding this comment.
Will remove this once spacecat shared configuration model is merged.
added 3 commits
September 11, 2025 19:41
- Add PATCH /configurations/sandbox endpoint - Support updating sandbox audit configurations for multiple audit types - Simplify validation to basic input checking (spacecat-shared handles business rules) - Remove complex validation and excessive logging
… API - Update OpenAPI documentation to use cooldownHours instead of expire - Update test cases to use cooldownHours for better clarity - Add comprehensive OpenAPI documentation for sandbox configuration endpoint - Improve API clarity: cooldownHours better describes rate limiting behavior - All tests passing with 100% coverage
Kanishkavijay39
changed the title
added 2 commits
September 16, 2025 19:25
…ion updates - spacecat-shared merged with sandbox configuration model updates - redeploy needed to get updated dependencies with updateSandboxAuditConfig method
Kanishkavijay39
force-pushed
the
SITES-sandbox-audit-configuration
branch
from
be95367 to
f5b6598
Compare
solaris007
approved these changes
Sep 17, 2025
|
|
||
| const { sandboxConfigs } = context.data || {}; | ||
|
|
||
| if (!sandboxConfigs || typeof sandboxConfigs !== 'object') { |
There was a problem hiding this comment.
could use isObject or even isNonEmptyObject from spacecat-shared-utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Sandbox Configuration API
Problem
Need API endpoint to manage sandbox audit settings without code deployments.
Solution
Adds
PATCH /configurations/sandboxendpoint for runtime sandbox audit management.Changes
New API Endpoint:
PATCH /configurations/sandbox- Update sandbox audit configurationx-api-keyauthentication{ sandboxConfigs: { "audit-type": { cooldownHours: "3", enabled: true } } }Controller Updates:
ConfigurationController.updateSandboxConfig()methodAPI Documentation:
configuration-api.yamlOther:
ConfigurationDtoto includesandboxAuditsin responsesUsage
PATCH /configurations/sandbox { "sandboxConfigs": { "meta-tags": { "cooldownHours": "3", "enabled": true } } }Testing
Note: Requires spacecat-shared Configuration model updates.
Testing