- 
                Notifications
    You must be signed in to change notification settings 
- Fork 235
docs: updated documentation of reactive-controllers #5802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| 
 | 
| 📚 Branch Preview🔍 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs: 
 Deployed to Azure Blob Storage:  If the changes are expected, update the  | 
| Tachometer resultsCurrently, no packages are changed by this PR... | 
| Pull Request Test Coverage Report for Build 18845086285Details
 
 💛 - Coveralls | 
…eb-components into rajdeep/swc-429
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! This was quite the undertaking! Overall this is really, really good stuff. If left some comments and suggestions for changes.
… into rajdeep/swc-429
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this was a huge undertaking! The documentation and examples here look great overall, and I learned a lot reading them!
I left a few comments. I also see that there weren't docs for the system context resolution controller, that's probably the primary thing needing adjustment here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the "How it works" section of LanguageResolutionController!
I had one more suggestion. Also, do you think we should do SystemContextResolutionController?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Left one comment about the formatting where the system context resolution controller was added in the README, otherwise I think this is good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is AMAZING! i learned a ton!
Description
This PR provides a comprehensive update to all reactive controller documentation files, ensuring complete API coverage, accessibility guidance, and practical examples. This addresses the requirements for fully documenting each controller's properties, methods, events, CSS properties, tokens, and accessibility considerations.
Changes
Updated 7 documentation files:
Added 1 documentation file:
What's New
Full API Documentation
Accessibility
Enhanced Examples
(forms, navigation, lazy loading, etc.)Other Improvements
PendingStateControllerdeprecation consideration(SWC-1119, SWC-1255, SWC-459)READMEMotivation and context
The existing documentation was missing critical information:
Related issue(s)
Screenshots (if appropriate)
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
Manual Test Case
Breaking Changes
None - documentation only.
Device review