Skip to content

Conversation

@rubencarvalho
Copy link
Contributor

@rubencarvalho rubencarvalho commented Oct 28, 2025

Description

This PR standardizes the monorepo workspace and package naming conventions and renames directories for consistency.

Changes made:

  1. Renamed directories:

    • first-gen/1st-gen/
    • second-gen/2nd-gen/
  2. Renamed workspace packages for consistency:

    • 1st-gen workspace: @adobe/spectrum-web-components@spectrum-web-components/1st-gen
    • 2nd-gen workspace: @adobe/swc@spectrum-web-components/2nd-gen
    • 2nd-gen core package: @swc/core@spectrum-web-components/core
    • 2nd-gen components package: @swc/components@adobe/swc
  3. Updated all package references throughout the codebase:

    • All package.json files (dependencies, workspace commands, directory paths)
    • All TypeScript/JavaScript source files (imports)
    • Configuration files (tsconfig, vite, webpack, storybook)
    • Build scripts and tooling
    • Test and story files
    • Root workspace configuration
  4. Added explicit .js extensions to all relative imports in 2nd-gen:

    • Updated all relative imports to use .js extensions
    • Simplified @spectrum-web-components/core package.json exports from 19 individual entries to 5 wildcard patterns
    • Ensures compatibility with 1st-gen imports and follows ES module standards
      • Added import/extensions rule to require .js extensions on relative imports in 2nd-gen

Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • Verify directory structure is updated

    1. Confirm 1st-gen/ and 2nd-gen/ directories exist
    2. Confirm old first-gen/ and second-gen/ directories are removed
    3. Expect all paths in configs and package.json files to reference new directory names
  • Verify workspace commands work correctly

    1. Run yarn build from root - should build both 1st-gen and 2nd-gen
    2. Run yarn workspace @spectrum-web-components/1st-gen build - should build 1st-gen
    3. Run yarn workspace @spectrum-web-components/2nd-gen build - should build 2nd-gen
    4. Expect all builds to complete successfully
  • Verify CI passes

    1. Expect all tests to pass

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2025

⚠️ No Changeset found

Latest commit: 41429ec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rubencarvalho rubencarvalho changed the base branch from main to barebones October 28, 2025 11:31
@rubencarvalho rubencarvalho force-pushed the ruben/barebones-cleanup branch from 6617cd1 to b8588c4 Compare October 28, 2025 11:38
@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2025

📚 Branch Preview

🔍 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5838

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@github-actions
Copy link
Contributor

Tachometer results

Currently, no packages are changed by this PR...

@rubencarvalho rubencarvalho changed the title Ruben/barebones cleanup chore: standardize package and workspace naming conventions Oct 28, 2025
@rubencarvalho rubencarvalho marked this pull request as ready for review October 28, 2025 12:59
@rubencarvalho rubencarvalho requested a review from a team as a code owner October 28, 2025 12:59
@rubencarvalho rubencarvalho force-pushed the ruben/barebones-cleanup branch from b3cee91 to fe5761e Compare October 28, 2025 13:03
@rubencarvalho rubencarvalho force-pushed the ruben/barebones-cleanup branch from fe5761e to be8171c Compare October 28, 2025 14:28
@rubencarvalho rubencarvalho added Status: Ready for review PR ready for review or re-review. 2nd gen These issues or PRs map to our 2nd generation work to modernizing infrastructure. High Priority PR Review PR is a high priority and should be reviewed ASAP labels Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2nd gen These issues or PRs map to our 2nd generation work to modernizing infrastructure. High Priority PR Review PR is a high priority and should be reviewed ASAP Status: Ready for review PR ready for review or re-review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants