-
Couldn't load subscription status.
- Fork 235
chore: standardize package and workspace naming conventions #5838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: barebones
Are you sure you want to change the base?
Conversation
|
6617cd1 to
b8588c4
Compare
📚 Branch Preview🔍 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
Tachometer resultsCurrently, no packages are changed by this PR... |
b3cee91 to
fe5761e
Compare
fe5761e to
be8171c
Compare
Description
This PR standardizes the monorepo workspace and package naming conventions and renames directories for consistency.
Changes made:
Renamed directories:
first-gen/→1st-gen/second-gen/→2nd-gen/Renamed workspace packages for consistency:
@adobe/spectrum-web-components→@spectrum-web-components/1st-gen@adobe/swc→@spectrum-web-components/2nd-gen@swc/core→@spectrum-web-components/core@swc/components→@adobe/swcUpdated all package references throughout the codebase:
package.jsonfiles (dependencies, workspace commands, directory paths)Added explicit
.jsextensions to all relative imports in 2nd-gen:.jsextensions@spectrum-web-components/corepackage.json exports from 19 individual entries to 5 wildcard patternsimport/extensionsrule to require.jsextensions on relative imports in 2nd-genAuthor's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
Verify directory structure is updated
1st-gen/and2nd-gen/directories existfirst-gen/andsecond-gen/directories are removedVerify workspace commands work correctly
yarn buildfrom root - should build both 1st-gen and 2nd-genyarn workspace @spectrum-web-components/1st-gen build- should build 1st-genyarn workspace @spectrum-web-components/2nd-gen build- should build 2nd-genVerify CI passes