Skip to content

Conversation

theRealPadster
Copy link

πŸ”— Linked issue

#1008

❓ Type of change

  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This adds a test for nested belongsTo relationships, and checks for nulls. Right now BaseModel.toObject() throws an error when the model has a null preloaded relationship.

TypeError: Cannot read properties of null (reading 'toObject')
    at /app/node_modules/@adonisjs/lucid/build/src/Orm/BaseModel/index.js:1507:93
    at Array.reduce (<anonymous>)
    at Proxy.toObject (/app/node_modules/@adonisjs/lucid/build/src/Orm/BaseModel/index.js:1505:56)
    at /app/node_modules/@adonisjs/lucid/build/src/Orm/BaseModel/index.js:1507:93
    at Array.reduce (<anonymous>)
    at Proxy.toObject (/app/node_modules/@adonisjs/lucid/build/src/Orm/BaseModel/index.js:1505:56)
    at /app/node_modules/@adonisjs/lucid/build/src/Orm/BaseModel/index.js:1507:93
    at Array.reduce (<anonymous>)
    at Proxy.toObject (/app/node_modules/@adonisjs/lucid/build/src/Orm/BaseModel/index.js:1505:56)
    at new AdObject (/app/app/Libraries/Algolia/classes/AdObject.ts:16:25)

Should I add the fix in this PR as well? It will resolve #1008

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@theRealPadster theRealPadster marked this pull request as ready for review March 23, 2024 18:46
@theRealPadster
Copy link
Author

I think this should be good to go. The test does fail. Would the best practice be to include the fix in this PR or a separate one?

Copy link

stale bot commented Apr 26, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Abandoned Dropped and not into consideration label Apr 26, 2025
@theRealPadster
Copy link
Author

Bump...

@stale stale bot removed the Status: Abandoned Dropped and not into consideration label Apr 26, 2025
@RomainLanz
Copy link
Member

Hey @theRealPadster! πŸ‘‹πŸ»

Could you please push this fix to the latest version of Lucid instead of 18.x?

Copy link

stale bot commented Jul 18, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Abandoned Dropped and not into consideration label Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Abandoned Dropped and not into consideration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants