Skip to content

Conversation

TonyBagnall
Copy link
Contributor

@TonyBagnall TonyBagnall commented Jul 28, 2025

Reorganise the forecasting module as follows

forecasting
--- stats
ETS, ARIMA
--- deep_learning (when we have some)
--- machine_learning (when we have some)
--- utils (including nelder mead)
--- tests

Also rename ETSForecaster as ETS

edit: when sorting out the API docs I noticed that there were still incorrect references to registry, so also changed them here

TonyBagnall and others added 30 commits May 24, 2025 14:43
…bool, and fix bug with it not operating on differemced data
@aeon-actions-bot aeon-actions-bot bot added the enhancement New feature, improvement request or other non-bug code enhancement label Jul 28, 2025
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ enhancement ].
I would have added the following labels to this PR based on the changes made: [ forecasting ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Push an empty commit to re-run CI checks

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub is showing some of these as new files rather than moved i.e. ARIMA and the utils. Can you check that these arent duplicates or contents from another PR

@TonyBagnall
Copy link
Contributor Author

GitHub is showing some of these as new files rather than moved i.e. ARIMA and the utils. Can you check that these arent duplicates or contents from another PR

that will be because I branched this of the ARMA branch I assume

@TonyBagnall TonyBagnall requested a review from alexbanwell1 July 31, 2025 15:24
Copy link
Contributor

@alexbanwell1 alexbanwell1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine now

@alexbanwell1 alexbanwell1 merged commit e458892 into main Jul 31, 2025
31 of 32 checks passed
@alexbanwell1 alexbanwell1 deleted the ajb/forecasting_refactor branch July 31, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, improvement request or other non-bug code enhancement forecasting Forecasting package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants