-
Notifications
You must be signed in to change notification settings - Fork 216
[ENH] Forecasting refactor #2962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…oducing the expected results
…bool, and fix bug with it not operating on differemced data
…e without refitting the model
…into arb/base_arima
Thank you for contributing to
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub is showing some of these as new files rather than moved i.e. ARIMA and the utils. Can you check that these arent duplicates or contents from another PR
that will be because I branched this of the ARMA branch I assume |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine now
Reorganise the forecasting module as follows
forecasting
--- stats
ETS, ARIMA
--- deep_learning (when we have some)
--- machine_learning (when we have some)
--- utils (including nelder mead)
--- tests
Also rename ETSForecaster as ETS
edit: when sorting out the API docs I noticed that there were still incorrect references to registry, so also changed them here