Skip to content

Conversation

Cyril-Meyer
Copy link
Contributor

@Cyril-Meyer Cyril-Meyer commented Oct 7, 2025

Reference Issues/PRs

Fixes #3086

What does this implement/fix? Explain your changes.

Add encoding="utf-8" parameter to load_from_ts_file.

def load_from_ts_file(
    full_file_path_and_name,
    replace_missing_vals_with="NaN",
    return_meta_data=False,
    return_type="auto",
    encoding="utf-8"
):

This makes no changes for 99% of usages, but when a .ts file is not UTF-8 encoded, user can specify its encoding.
Example of fixed situation :

import aeon.datasets
x, y = aeon.datasets.load_from_ts_file('K:/Monash_UEA_UCR_Regression_Archive/BIDMC32SpO2/BIDMC32SpO2_TRAIN.ts', encoding='cp1252')

Does your contribution introduce a new dependency? If yes, which one?

No.

Any other comments?

No.

PR checklist

For all contributions
  • I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you after the PR has been merged.
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.

@aeon-actions-bot aeon-actions-bot bot added bug Something isn't working datasets Datasets and data loaders labels Oct 7, 2025
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ bug ].
I have added the following labels to this PR based on the changes made: [ datasets ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Regenerate expected results for testing
  • Push an empty commit to re-run CI checks

@Cyril-Meyer
Copy link
Contributor Author

As said in the issue, this PR do not add tests for this, but I do not think its necessary to add a non utf-8 dataset to the data folder just for this cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working datasets Datasets and data loaders

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] load_regression fails on BIDMC32HR

1 participant