Code Review Ottavia & Raúl #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hola muyayo,
Después de darle un buen repaso a tu fakeStore (mas fake que store), te queremos dar la enhorabuena por el proyecto.
En lineas generales esta muy bien, tanto en la parte de estilo como en la parte de código.
Hay algún detallito por pulir, que hemos dejado en los comentarios (si tienes la extension anchor tags , haz un scann y las encontraras como "todos" )
Sobre el problema que teníamos con el redirect después de hacer refresh, aun estando el usuario logged in, le dejamos a Marta una solución en su código, dile que la comparta contigo.
Sería genial si, una vez implementases el shopping cart en el proyecto de Mearn, lo hicieses también en este, eso terminaría de redondear este proyecto y seria una muy buena baza para posteriores entrevistas.
Muy buen trabajo y sigue manteniendo el nivel ;)