-
Notifications
You must be signed in to change notification settings - Fork 251
[add] partial elements in Effect.Monad.Partial module #2796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hi @e-mniang, thanks for the contribution! I've requested reviews from people who may be more capable of assessing this than me. However, for starters please could you make sure that your proposed new file has the same formatting as all the other files in the standard library? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks for your comment.
I made some changes and I hope the file is now in the correct format. :)
@MatthewDaggitt requested my review, but ahead of any such, my first thought would be: why is the record ↯ {a} (A : Set a) : Set ω where
field
ℓ : Level
Dom : Set ℓ
elt : Dom → A I realise that An alternative might be to define 'partial function from I'll try to look at the 1lab to see what's going on there (oh, some quite delicate things under the hood about a small type of propositions... and the level that such a thing should live at. Hmmm). And perhaps also go back to Eugenio Moggi's PhD thesis, and Scott's "Identity and Existence in Intuitionistic Logic" (Springer LNM 753) for a refresher course... Also: |
We indeed have e.g. https://agda.github.io/agda-stdlib/v2.2/Effect.Monad.Partiality.html |
So... that leaves some tricky design choices as to how to proceed with this PR, if we think it is worth doing so:
So... overall my conclusion (for the time being, at least) is that this PR probably shouldn't proceed, unless there are compelling answers to the above questions? |
Delay monads like the one in As for impredicativity, this isn't essential aside from the usual caveats about predicative order theory: see Tom de Jong's thesis for more. Finally, we could prove the monad laws, though this would require some setoid-fu that quotients away the choice of witnesses of definedness. |
Also, I forgot to mention that modulo proof-relevance, this is the free pointed DCPO, whereas delay-like monads are aiming to be the free omega-CPO. |
That level of 'documentation' would be worth putting in the PR, including adding some to the current Partiality monad. |
@TOTBWF wrote:
Thanks Reed for this. Does this (ie. 'free pointed DCPO') mean that only decidable domains of partial definitions are being considered (because we can distinguish the point?), or is that a misunderstanding based on Also: a propos free-ness (and #1962 #2539 etc. for @JacquesCarette 's shopping list of examples with which to explore candidate designs), are we going to add the relevant universal properties, suitably phrased, at some point downstream... ? |
This PR introduces the
↯
type for partial elements along with its associated functions for binding, mapping, and applying.Partial computations — such as non-terminating functions or computations undefined on some input — are represented by a domain of definition and an associated function. The type ↯ A ℓ encapsulates such partial values over a type A by:
Basic constructors:
Functions:
Source: https://1lab.dev/Data.Partial.Base.html#1132 and @TOTBWF